search

Azure-Samples / openai-chat-app-quickstart

A simple chat application that uses managed identity for Azure OpenAI access. Designed for deployment on Azure Container Apps with the Azure Developer CLI.
MIT License
154 stars 85 forks source link

Updates to allow the API version values as part of the deployment #66

Closed Gergues closed 6 months ago

Gergues commented 8 months ago

Purpose

Adding the option for the api version string value as part of the chat setup added AZURE_OPENAI_VERSION as environment variable for both the container and the app to use.

Does this introduce a breaking change?

[x] Yes
[ ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[x] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Documentation content changes
[ ] Other... Please describe:
Gergues commented 8 months ago

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

Gergues commented 8 months ago

I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

On Jan 29, 2024, at 13:18, microsoft-github-policy-service[bot] @.***> wrote:

(default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.

pamelafox commented 8 months ago

We usually store the version in the code as our code is often dependent on particular features in the API. What's the use case where your code isn't dependent on the API version? (It's similar to pinning Python SDKs, we know which versions this code works with)

Gergues commented 8 months ago

I noticed that I can have the same API (gpt 35) under the same name and with 2 versions / deployment apiversion

When I ran the code as-is this did not work for sure , as there were other features in the service response that did not map properly I was able to see that when comparing the 2 versions (OPEN AI service swagger) . You may not see this when you deploy one instance , but will see it as you deploy an instance today and another one in 3 month

Thanks

On Jan 29, 2024, at 16:03, Pamela Fox @.***> wrote:

We usually store the version in the code as our code is often dependent on particular features in the API. What's the use case where your code isn't dependent on the API version? (It's similar to pinning Python SDKs, we know which versions this code works with)

— Reply to this email directly, view it on GitHub https://github.com/Azure-Samples/chatgpt-quickstart/pull/66#issuecomment-1915561224, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABZCOELMZ4YPWFWWZ7MT74DYRAFAVAVCNFSM6AAAAABCP43N7KVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJVGU3DCMRSGQ. You are receiving this because you were mentioned.

pamelafox commented 6 months ago

I made some changes and merged, thanks!