Azure-Samples / openai

The repository for all Azure OpenAI Samples complementing the OpenAI cookbook.
https://aka.ms/azure-openai
MIT License
1.11k stars 375 forks source link

[E2ESolutions/AOAISearchDemo] Missing Cosmos DB Endpoint in KeyVault secrets #12

Open renepajta opened 1 year ago

renepajta commented 1 year ago

Please provide us with the following information:

This issue is for a: (mark with an x)

- [X ] bug report -> please search issues before submitting
- [ ] feature request
- [ ] documentation issue or request
- [ ] regression (a behavior that used to work and stopped in a new release)

Minimal steps to reproduce

git clone cd openai/End_to_end_Solutions/AOAISearchDemo azd auth login --tenant-id azd up

Any log messages given by the failure

Running "prepopulate.py" usage: prepopulate.py [-h] [--entities_path ENTITIES_PATH] [--permissions_path PERMISSIONS_PATH] [--cosmos_db_endpoint COSMOS_DB_ENDPOINT] [--cosmos_db_key COSMOS_DB_KEY] [--cosmos_db_name COSMOS_DB_NAME] [--cosmos_db_entities_container_name COSMOS_DB_ENTITIES_CONTAINER_NAME] [--cosmos_db_permissions_container_name COSMOS_DB_PERMISSIONS_CONTAINER_NAME] prepopulate.py: error: argument --cosmos_db_endpoint: expected one argument

Expected/desired behavior

The azd up finishes successfully. Azure Cosmos DB Endpoint secret is not created as keyvault secret. See file .\End_to_end_Solutions\AOAISearchDemo\infra\core\database\cosmos-database.bicep

Missing piece:

module azureCosmosKeySecret '../keyvault/keyvault_secret.bicep' = if(addKeysToVault) { name: 'AZURE-COSMOS-ENDPOINT' params: { keyVaultName: keyVaultName secretName: 'AZURE-COSMOS-ENDPOINT' secretValue: account.properties.documentEndpoint } }

OS and Version?

Windows 11

Versions

Mention any other details that might be useful


Thanks! We'll be in touch soon.

bchuecos commented 1 year ago

Thank you for bringing this to our attention, we've updated the repo with a few fixes to the azd deployment process. Please re-clone the repo and try deploying again