Azure-Samples / qdrant-azure

Qdrant Vector Database on Azure Cloud
MIT License
89 stars 22 forks source link

Bicep support and dev container #17

Closed mcollier closed 1 year ago

mcollier commented 1 year ago

Purpose

Does this introduce a breaking change?

[ ] Yes
[X] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[X] Feature
[X] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[X] Documentation content changes
[ ] Other... Please describe:

How to Test

What to Check

Verify that the following are valid

Other Information

mcollier commented 1 year ago

@tawalke I pushed an update which replaces the previous ARM templates with an ARM template generated from the Bicep files (using the az bicep build --file main.bicep --outfile azuredeploy.json command). The README files were updated to link to the new azuredeploy.json files.

tawalke commented 1 year ago

@tawalke I pushed an update which replaces the previous ARM templates with an ARM template generated from the Bicep files (using the az bicep build --file main.bicep --outfile azuredeploy.json command). The README files were updated to link to the new azuredeploy.json files.

I would like this to additional option vs. in lieu of so folks have both. Can you update do this is an additional offering of bicep. Thanks!

tawalke commented 1 year ago

This repo is going to be changed to public today.

mcollier commented 1 year ago

@tawalke I’m not understanding. Can you please expand on the request?

The PR contains both an ARM and Bicep template.

tawalke commented 1 year ago

@mcollier reviewing.