Make DNS name unique for each deployment - Githubissues

Azure-Samples / qdrant-azure

Qdrant Vector Database on Azure Cloud

MIT License

89 stars 22 forks source link

Make DNS name unique for each deployment #22

Open glahaye opened 1 year ago

glahaye commented 1 year ago

Purpose

More than a single ACI deployment can live in each region with this change

Does this introduce a breaking change?

[ ] Yes
[ x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Get the code
Deploy to multiple resource groups within the same region

tawalke commented 1 year ago

This may be already covered in ARM template using function to add to name within character restriction which was reviewed previously. Will verify this is the case for both the ARM & bicep template.

Thanks.