Azure-Samples / rag-postgres-openai-python

A RAG app to ask questions about rows in a database table. Deployable on Azure Container Apps with PostgreSQL Flexible Server.
MIT License
263 stars 132 forks source link

Restructure files #56

Closed john0isaac closed 4 months ago

john0isaac commented 5 months ago

Purpose

Fix #52

Does this introduce a breaking change?

When developers merge from main and run the server, azd up, or azd deploy, will this produce an error? If you're not sure, try it out on an old environment.

[ ] Yes
[x] No

Type of change

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Code quality checklist

See CONTRIBUTING.md for more details.

pamelafox commented 4 months ago

mypy is unhappy (as usual). I'm placating it.

john0isaac commented 4 months ago

What's weird is that these tests passed last Thursday. I upgraded my local mypy version and got the same errors. I think it's the latest release. Thanks! For fixing it.

pamelafox commented 4 months ago

@john0isaac Yep latest mypy came out last week, and caused a bunch of issues all over. It broke azure-search-openai-demo CI cuz of https://github.com/python/mypy/issues/17550 which I've also just fixed.