Azure-Samples / rag-postgres-openai-python

A RAG app to ask questions about rows in a database table. Deployable on Azure Container Apps with PostgreSQL Flexible Server.
MIT License
263 stars 132 forks source link

Port to azd env get value #58

Closed pamelafox closed 3 months ago

pamelafox commented 4 months ago

Purpose

This ports to azd env get-value, which will be in a future azd release. https://github.com/Azure/azure-dev/pull/4080

Does this introduce a breaking change?

When developers merge from main and run the server, azd up, or azd deploy, will this produce an error? If you're not sure, try it out on an old environment.

[ ] Yes
[X] No

Type of change

[ ] Bugfix
[ ] Feature
[X] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Code quality checklist

See CONTRIBUTING.md for more details.

john0isaac commented 3 months ago

@pamelafox before you merge remove echo=True from the engine creation The logs are full of sqlalchmey logs https://github.com/Azure-Samples/rag-postgres-openai-python/blob/bba4c88b442710307ff6df45ce90b532bf675288/src/backend/fastapi_app/postgres_engine.py#L33

pamelafox commented 3 months ago

Lol I kind of love those logs, its like the Matrix, but good point, I think I accidentally turned that to True in a recent branch. Turning to False.