Azure-Samples / rag-postgres-openai-python

A RAG app to ask questions about rows in a database table. Deployable on Azure Container Apps with PostgreSQL Flexible Server.
MIT License
263 stars 131 forks source link

allow setting AZURE_OPENAI_LOCATION in env #76

Closed hund030 closed 3 months ago

hund030 commented 3 months ago

Purpose

Unblock azd up --no-prompt by setting AZURE_OPENAI_LOCATION in env.

Does this introduce a breaking change?

When developers merge from main and run the server, azd up, or azd deploy, will this produce an error? If you're not sure, try it out on an old environment.

[ ] Yes
[x] No

Type of change

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

Code quality checklist

See CONTRIBUTING.md for more details.

N/A

pamelafox commented 3 months ago

Thanks! I tested this with a brand new env, and it does still prompt for location in that case, since it has no default value, so this works. Thanks! Feel free to send same PR for other repos if they are blocked in th same way.