Azure-Samples / service-fabric-java-getting-started

Getting started with Service Fabric with Java
20 stars 34 forks source link

Scripts/upgrade.sh was not executed correctly #45

Closed tomleetaiwan closed 5 years ago

tomleetaiwan commented 6 years ago

The line needs to be modified from

sfctl application upgrade --app-id VotingApplication --app-version ${version} --parameters "" --mode "Monitored"

to below line for Service Fabric for Linux

sfctl application upgrade --app-id VotingApplication --app-version ${version} --parameters "{}" --mode "Monitored"

otherwise sfctl will show the error message

Loading JSON from string input failed. You can also pass the json argument in a .txt file. To do so, set argument value to the absolute path of the text file prefixed by "@". If you have passed in a file name, please ensure that the JSON is correct. Error: No JSON object could be decoded

rapatchi commented 6 years ago

Thanks for reporting this will fix them accordingly

rapatchi commented 5 years ago

@tomleetaiwan fixed this in #46