Updated README.md to include ingress class annotations - Githubissues

Azure-Samples / virtual-node-autoscale

A sample application to demonstrate Autoscale with AKS Virtual Nodes

MIT License

73 stars 40 forks source link

Updated README.md to include ingress class annotations #35

Closed knee-berts closed 5 years ago

knee-berts commented 5 years ago

Purpose

The walk through doesn't work if you use an ingress class != nginx. Added some instructions and commands to remedy that.

Does this introduce a breaking change?

[ ] Yes
[ x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ x] Documentation content changes
[ ] Other... Please describe:

How to Test

Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install

Test the code

What to Check

Verify that the following are valid

...

Other Information

rbitia commented 5 years ago

Thanks! I'll try it out next week :)