search

Azure / ADX-in-a-Day

Hands on experience on Azure Data Explorer and Kusto Query Languages(KQL)
MIT License
124 stars 37 forks source link

improve accessibility | contrast of charm #15

Closed ingebeumer closed 1 year ago

ingebeumer commented 1 year ago

Hello,

Please consider improving accessibility of ADX-in-a-Day by choosing a charm (in questions that require an answer) that has better contrast when using a darker theme in GitHub.

Appearance dark dimmed: image Appearance dark default: image Appearance light default: image

hfleitas commented 1 year ago

@ingebeumer Thank you! We're considering these instead. Do you have a preference/recommendation? We appreciate your feedback towards improving the accessibility.

  1. :dart: 🎯
  2. :trophy: 🏆
  3. :white_check_mark: ✅
ingebeumer commented 1 year ago

@hfleitas, although I'm not an accessibility SME I prefer option 3 the checkmark. They are tasks you need to complete to earn the badge so the checkmark makes most sense to me and it's a charm that gets your attention. Dark dimmed: image Light default: image Dark default: image

hfleitas commented 1 year ago

Confirmed with our accessibility SME to use the ✅

Main repo fixed ✅ Lab 1 repo fixed ✅ Lab 2 repo fixed ✅ Quiz 1 fixed ✅ Quiz 2 fixed ✅

Thank you

ingebeumer commented 1 year ago

Looks great @hfleitas, I much appreciate the improvement.