Preview feature UI dialog popup

Azure / AKS-Construction

Accelerate your onboarding to AKS with; Helper Web App, bicep templating and CI/CD samples. Flexible & secure AKS baseline implementations in a Microsoft + community maintained reference implementation.

https://azure.github.io/AKS-Construction/

MIT License

356 stars 165 forks source link

Preview feature UI dialog popup #571

Closed nellyk closed 1 year ago

nellyk commented 1 year ago

PR Summary

This closes #421 and enables dialogs https://developer.microsoft.com/en-us/fluentui#/controls/web/dialog when preview* features are clicked as shown below

aksconsutrction

PR Checklist

[ x] PR has a meaningful title
[ x] Summarized changes
[x ] This PR is ready to merge and is not Work in Progress
[x ] Link to a filed issue
[x ] Screenshot of UI changes (if PR includes UI changes)

Gordonby commented 1 year ago

Looks good, i do think we can make the link more accessible to the user by adding another button to the dialog footer which will open the link in a new window/tab.

https://developer.microsoft.com/en-us/fluentui#/controls/web/dialog#usage

nellyk commented 1 year ago

@Gordonby Thank you for reviewing. I've made changes to allow someone to open the link in a new tab.

dialog