search

Azure / AKS-Construction

Accelerate your onboarding to AKS with; Helper Web App, bicep templating and CI/CD samples. Flexible & secure AKS baseline implementations in a Microsoft + community maintained reference implementation.
https://azure.github.io/AKS-Construction/
MIT License
356 stars 165 forks source link

New default needed for osDiskSizeGb parameter #612

Closed Gordonby closed 10 months ago

Gordonby commented 1 year ago

Describe the bug The current default value for parameter osDiskSizeGB is 0. The effect of this is that the AKS RP ignores the value and instead uses the value of 128GB.

As the size of the Ubuntu image is ~30GB, this means we're unnecessarily defaulting to a much bigger size disk than is needed. Windows nodes, will indeed need a larger disk.

I think this is also related to #592

To Reproduce Deploy a cluster and inspect the disk size

Expected behavior An appropriately size disk will be chosen by AKSC to fit the requirement of either Linux or Windows. (32 or 128 i believe would be a good choice.)

Screenshots image

Additional context

" Standard Ubuntu server image from Marketplace is about 30 GiB. The temp disk size must be equal to or larger than 30 GiB to enable Ephemeral OS disk on the temporary storage. Standard_B4ms has a temporary storage size of 32 GiB, which can fit the 30 GiB OS disk. Upon creation of the VM, the temp disk space would be 2 GiB."

"Standard Windows Server images from the Marketplace are about 127 GiB, meaning that you need a VM size with a cache equal to or larger than 127 GiB. The Standard_DS3_v2 has a cache size of 127 GiB, which is large enough. In this case, the Standard_DS3_v2 is the smallest size in the DSv2 series that you can use with this image."

ref: https://learn.microsoft.com/en-us/samples/azure-samples/aks-ephemeral-os-disk/aks-ephemeral-os-disk/

github-actions[bot] commented 1 year ago

Issue smells stale, no activity for 30 days. Stale Label will be removed if the issue is updated, otherwise closed in a month.

iamvighnesh commented 12 months ago

@Gordonby I am happy to make this quick change. I suggest we use the following:

github-actions[bot] commented 11 months ago

Issue smells stale, no activity for 30 days. Stale Label will be removed if the issue is updated, otherwise closed in a month.

Gordonby commented 10 months ago

I wonder if the Windows default could be more configurable.... 100GB would require quite a big VM to use an ephemeral disk. I'd need to check vm disk sizes, but something more like 50GB would be good.

pjlewisuk commented 10 months ago

Resolved in #661