search

Azure / AKS-Construction

Accelerate your onboarding to AKS with; Helper Web App, bicep templating and CI/CD samples. Flexible & secure AKS baseline implementations in a Microsoft + community maintained reference implementation.
https://azure.github.io/AKS-Construction/
MIT License
356 stars 165 forks source link

Bug: AKS Construction does not pass necessary parameters for CNI Overlay networking #617

Closed pjlewisuk closed 10 months ago

pjlewisuk commented 1 year ago

Describe the bug When you select "CNI Overlay Network" and "Custom Networking" on the "Networking Details" tab, you get to define your custom network configuration, including parameters for POD Network, Service Network and DNS Service IP under Kubernetes Networking Configuration. However, the Pod Network and Service Network parameters are not passed into the Deployment script generated by AKS Construction:

image

podCidr is missing from the deployment command: image

To Reproduce Steps to reproduce the behavior:

  1. Go to AKS Construction homepage
  2. Navigate to "Networking Details"
  3. Check the "CNI Overlay Networking" box under "CNI Features"
  4. Select "Custom Networking" option under "Default or Custom VNET"
  5. Enter custom values for "VNET Address space", "AKS Nodes subnet", "POD Network", "Service Network", and "DNS Service IP"
  6. Navigate to the "Bash" or "PowerShell" tabs under "Deploy Cluster", and examine the output
  7. Note missing podCidr parameter (even though networkPluginMode=Overlay is set)

Expected behavior podCidr parameter should get passed to the deployment command so that CNI Overlay networking is set up correctly.

Screenshots If applicable, add screenshots to help explain your problem.

Additional context Add any other context about the problem here.

pjlewisuk commented 1 year ago

If I add the podCidr parameter to the az deployment command prior to running it, with a "Default Networking" cluster configuration, it does not take effect, even though I can see it gets passed to the deployment. I presume this is because the custom_vnet parameter is set to false, and so it gets ignored?

If I add the podCidr parameter when "Custom Networking" is used, I get the cluster configuration I expected: with nodes and pods running in separate subnets. I presume this is because custom_vnet is set to true.

khowling commented 1 year ago

@samaea pls update with IP CIDR not passed

github-actions[bot] commented 1 year ago

Issue smells stale, no activity for 30 days. Stale Label will be removed if the issue is updated, otherwise closed in a month.

pjlewisuk commented 1 year ago

Bump to reopen