Choosing a more secure option should not come with a warning - #621

Azure / AKS-Construction

Accelerate your onboarding to AKS with; Helper Web App, bicep templating and CI/CD samples. Flexible & secure AKS baseline implementations in a Microsoft + community maintained reference implementation.

https://azure.github.io/AKS-Construction/

MIT License

356 stars 165 forks source link

Choosing a more secure option should not come with a warning - #621 #623

Closed asalbers closed 1 year ago

asalbers commented 1 year ago

PR Summary

Wanted more encouraging language for those that are choosing a private cluster. Changed two files clusterTab.js and principals.json

Fixes #621

PR Checklist

[x] PR has a meaningful title
[x] Summarized changes
[x] This PR is ready to merge and is not Work in Progress
[x] Link to a filed issue
[x] Screenshot of UI changes (if PR includes UI changes)

khowling commented 1 year ago

This looks good, thank you @asalbers. @asalbers @mosabami , do you mined it we change the message slightly, I dont think its necessarily the best option for every company / environment / workload. Can we change to something like "Most secure option for your apps, but requires most involved access management" (can remove the "Note" text)

asalbers commented 1 year ago

This looks good, thank you @asalbers. @asalbers @mosabami , do you mined it we change the message slightly, I dont think its necessarily the best option for every company / environment / workload. Can we change to something like "Most secure option for your apps, but requires most involved access management" (can remove the "Note" text)

Updated

Gordonby commented 1 year ago

All the checks are passing now @mosabami . When you approve, the changes will merge, and as long as there's no unreleased bicep changes in main - this should go straight out.