Azure / AKS-Construction

Accelerate your onboarding to AKS with; Helper Web App, bicep templating and CI/CD samples. Flexible & secure AKS baseline implementations in a Microsoft + community maintained reference implementation.
https://azure.github.io/AKS-Construction/
MIT License
356 stars 165 forks source link

Add 'validate' parameter to use during releases #643

Open pjlewisuk opened 1 year ago

pjlewisuk commented 1 year ago

Is your feature request related to a problem? Please describe. Add a new parameter to be used during deployments and releases which can be used to set parameters or transform text within the helper during a release, e.g. changing az deployment group create to az deployment group create during the TestWebApp / Validation workflow.

Describe the solution you'd like Add a parameter that can be passed into the workflow to toggle behaviour for deployment testing. See https://github.com/Azure/AKS-Construction/pull/642/files for how to pass the parameter into PlayWright.

Describe alternatives you've considered A clear and concise description of any alternative solutions or features you've considered.

Additional context Add any other context or screenshots about the feature request here.

samaea commented 1 year ago

Is this still an issue or resolved as part of our previous conversations?

pjlewisuk commented 1 year ago

It came up in discussions during the last release, so yeah, I think it's still needed.

github-actions[bot] commented 1 year ago

Issue smells stale, no activity for 30 days. Stale Label will be removed if the issue is updated, otherwise closed in a month.

github-actions[bot] commented 11 months ago

Issue smells stale, no activity for 30 days. Stale Label will be removed if the issue is updated, otherwise closed in a month.