Azure / AKS-Construction

Accelerate your onboarding to AKS with; Helper Web App, bicep templating and CI/CD samples. Flexible & secure AKS baseline implementations in a Microsoft + community maintained reference implementation.
https://azure.github.io/AKS-Construction/
MIT License
356 stars 165 forks source link

Fixing inline code snippets so that they show up in dark theme #660

Closed TIGHEDEV closed 11 months ago

TIGHEDEV commented 12 months ago

PR Summary

Adding in a grey background colour to the code element so that regardless of whether the user is in light or dark theme there is a contrast in the text colour to the background so that it is visible in both themes.

Below are the screenshots of the fixed UI.

image

image

Screenshot below is how it used to appear in dark theme. The ".github/workflows" is clearly not visible in dark theme.

image

In the light theme the code snippets will now have a grey background surrounding the text. In my opinion this is good as most code snippets on the web use a background colour to differentiate the snippet from the rest of the text. Screenshot below is the original light theme without the changes of this PR. It is difficult to tell that the code snippet is different to any of the other surrounding text.

image

Link to the original issue: https://github.com/Azure/AKS-Construction/issues/629

PR Checklist