Azure / AKS-Construction

Accelerate your onboarding to AKS with; Helper Web App, bicep templating and CI/CD samples. Flexible & secure AKS baseline implementations in a Microsoft + community maintained reference implementation.
https://azure.github.io/AKS-Construction/
MIT License
356 stars 165 forks source link

Cannot use predefined system node pools and custom preset while JustUseSystemNodepool set to true #673

Closed SzymonSt closed 8 months ago

SzymonSt commented 10 months ago

Describe the bug If JustUseSystemNodepool all the system nodepool presets are ignored.

To Reproduce Steps to reproduce the behavior:

  1. Set JustUseSystemNodepool to true
  2. Define your own custom preset for system nodepool or use on of (highspec, standard, costoptimized)
  3. Deploy
  4. Observe system nodepool being depoyed with just systemPoolBase properites

Expected behavior System nodepool is created with config from custom/preset definition.

Additional context My config:

//---------Kubernetes Construction---------
//ref: https://github.com/Azure/AKS-Construction
module aksConstruction '../../../AKS-Construction/bicep/main.bicep' = {
  name: 'aksconst-${deploymentPostfix}'
  scope: resourceGroup(aksClusterName)
  params: {
    //General
    resourceName: aksClusterName
    enableTelemetry: false
    kubernetesVersion: '1.27.3'                   //ToBeParametrized
    AksPaidSkuForSLA: true
    enable_aad: true
    enableAzureRBAC: true
    keyVaultAksCSI: true
    JustUseSystemPool: true
    //Networking
    networkPlugin: 'azure'
    networkPolicy: 'azure'
    byoAKSSubnetId: subnetResource.id
    enablePrivateCluster: true
    serviceCidr: '172.0.0.0/20'                   //ToBeParametrized
    dnsServiceIP: '172.0.0.10'                    //ToBeParametrized
    //Compute
    SystemPoolType: 'Custom'
    SystemPoolCustomPreset:{
      vmSize: 'Standard_D8ds_v5'                  //ToBeParametrized
      count: 1                                    //ToBeParametrized
      maxPods: 200                                //ToBeParametrized
      minCount: 1
      maxCount: 2                                 //ToBeParametrized
      enableAutoScaling: true                     //ToBeParametrized
      availabilityZones: [
        '1'
        '2'
        '3'
      ]
    }
  }
}
SzymonSt commented 10 months ago

I've linked PR with proposed solution. Thanks in advance for review of bug issue and PR.

github-actions[bot] commented 9 months ago

Issue smells stale, no activity for 30 days. Stale Label will be removed if the issue is updated, otherwise closed in a month.