Azure / AKS-Landing-Zone-Accelerator

Official repository for the AKS Landing Zone Accelerator program
MIT License
207 stars 196 forks source link

[FEATURE] - Move the telemetrydeployment to module #121

Open jgardner04 opened 4 months ago

jgardner04 commented 4 months ago

**Is your feature request related to a problem?

When deploying the LZA Hub and Spoke Infrastructure via Bicep and GitHub Actions, the Create ESLZ Hub throws an warning during this step.

WARNING: /home/runner/work/AKS-Landing-Zone-Accelerator/AKS-Landing-Zone-Accelerator/Scenarios/AKS-Secure-Baseline-PrivateCluster/Bicep/03-Network-Hub/main.bicep(179,30) : Warning no-deployments-resources: Resource 'telemetrydeployment' of type 'Microsoft.Resources/deployments@2021-04-01' should instead be declared as a Bicep module.

The error links here: https://github.com/Azure/AKS-Landing-Zone-Accelerator/blob/e1090f080f226cd75299ceb6c91ba0591c602cf0/Scenarios/AKS-Secure-Baseline-PrivateCluster/Bicep/03-Network-Hub/main.bicep#L179

It happens again here: https://github.com/Azure/AKS-Landing-Zone-Accelerator/blob/e1090f080f226cd75299ceb6c91ba0591c602cf0/Scenarios/AKS-Secure-Baseline-PrivateCluster/Bicep/06-AKS-cluster/main.bicep#L249

Describe the solution you'd like This should be moved into a module to suppress this warning.