search

Azure / AKS-Landing-Zone-Accelerator

Official repository for the AKS Landing Zone Accelerator program
MIT License
212 stars 198 forks source link

Add build app image and push to ACR to the deployment steps #77

Closed mosabami closed 10 months ago

mosabami commented 1 year ago

The Readme file for the Build intelligent apps scenario provides instructions on how to deploy the scenario by using an image already build and hosted on dockerhub. We know customers would want to build their images themselves using dockerfiles. Update the instructions to add a NEW OPTION to have to user build their images using the az acr build command and used their built images in their deployment instead. decide if you want them to complete the instructions using the dockerhub image first then update it to use their ACR or make it an option they can choose from (build your image or use ours). The dockerfiles can be fund in the submodule (App folder)

Create a new branch out of the opernai-embeddings branch: https://github.com/Azure/AKS-Landing-Zone-Accelerator/tree/openai-embeddings/Scenarios/AKS-OpenAI-CogServe-Redis-Embeddings

Acceptance criteria:

  1. Update the manifest file providing a placeholder as the image name so users can update it with their acr name
  2. add instructions to the readme ensuring users understand that when they git clone the repository they must use the command git clone --recurse-submodules https://github.com/Azure/AKS-Landing-Zone-Accelerator so that the application code can be pulled from the repo that hosts it
  3. Add instructions on how to build the image using az acr build
  4. add instructions on how to update the placeholder in the deployment files
  5. the changes should apply to the two application images and redis image should be pulled from dockerhub to the user's acr
  6. this change must be optional
  7. PR submitted to the opernai-embeddings branch
mosabami commented 10 months ago

closed with #104