search

Azure / AKS

Azure Kubernetes Service
https://azure.github.io/AKS/
1.96k stars 306 forks source link

Missing prometheus.io/scrape annotation in coredns #2644

Open palmerabollo opened 2 years ago

palmerabollo commented 2 years ago

What happened:

Coredns pods are created with the annotation prometheus.io/port but the annotation prometheus.io/scrape is missing. That makes it hard to automatically scrape its metrics with an external Prometheus service.

What you expected to happen:

The coredns deployment must have an annotation prometheus.io/scrape: "true" added to its pod template.

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

This issue is related to https://github.com/Azure/AKS/issues/1364#issuecomment-577393996, #186 (>3y ago) and https://github.com/Azure/AKS/issues/345#issuecomment-651124515.

Environment:

ghost commented 2 years ago

Hi palmerabollo, AKS bot here :wave: Thank you for posting on the AKS Repo, I'll do my best to get a kind human from the AKS team to assist you.

I might be just a bot, but I'm told my suggestions are normally quite good, as such: 1) If this case is urgent, please open a Support Request so that our 24/7 support team may help you faster. 2) Please abide by the AKS repo Guidelines and Code of Conduct. 3) If you're having an issue, could it be described on the AKS Troubleshooting guides or AKS Diagnostics? 4) Make sure your subscribed to the AKS Release Notes to keep up to date with all that's new on AKS. 5) Make sure there isn't a duplicate of this issue already reported. If there is, feel free to close this one and '+1' the existing issue. 6) If you have a question, do take a look at our AKS FAQ. We place the most common ones there!

ghost commented 2 years ago

Triage required from @Azure/aks-pm

ghost commented 2 years ago

Action required from @Azure/aks-pm

ghost commented 2 years ago

Action required from @robbiezhang, @Kaarthis.

kaarthis commented 1 year ago

Will look into this , this semester seems a long hanging one.

zioproto commented 10 months ago

@kaarthis could we document in the AKS docs if doing the following:

Create a coredns-patcher.yaml file with the following content.

spec:
  template:
    metadata:
      annotations:
        prometheus.io/port: "9153"
        prometheus.io/scrape: "true"

Patch your cluster coredns deployment with the following command:

kubectl patch -n kube-system deploy coredns --patch "$(cat coredns-patcher.yaml)"

is an operation safe to persist the annotation across AKS upgrades ?

hterik commented 10 months ago

@kaarthis could we document in the AKS docs....

Why does the solution to everything in Azure involve finding the edge-case you missed somewhere in endless pages of documentation? Better if this is solved with pit-of-success defaults instead?

Are there scenarios where this annotation may break something or where it is not desired for other reasons?