Azure / AKS

Azure Kubernetes Service
https://azure.github.io/AKS/
1.95k stars 303 forks source link

[Feature] Node should have label of corresponding Virtual Machine resource id / VM name #3293

Open grzesuav opened 1 year ago

grzesuav commented 1 year ago

Is your feature request related to a problem? Please describe.

Each Node in AKS cluster have corresponding VirtualMachine/ VirtualMachineScaleSet. This information should be exposed via label on the node object, to make it easy to identify the underlying resource in azure.

It would be needed to cross reference metrics from Azure Metrics portal with other metrics, exposed via i.e. kube-state-metrics. Currently, from azure metric we can get VMName dimension, which does not match node name. Example:

Additional context https://github.com/kubernetes-sigs/cluster-api-provider-azure/issues/2610

kk-bavenkatachalam commented 1 year ago

Yeah, AKS nodepool should expose underlying vmss name. It would be useful in assigning new user defined identites which in turn would be used for accessing keyvault secrets/keys/certificates. https://learn.microsoft.com/en-us/azure/aks/csi-secrets-store-identity-access#use-a-user-assigned-managed-identity

Currently, we need to access MC_aksname_rgname resource group to get the underlying vmss. But if nodepool exposes vmss name there is no need to do this additional step.

There is also a similar request in the hashicorp/terraform-provider-azurerm repository but it cannot be fulfilled if AKS does not support this feature. https://github.com/hashicorp/terraform-provider-azurerm/issues/6217

ghost commented 1 year ago

Action required from @Azure/aks-pm

ghost commented 1 year ago

Issue needing attention of @Azure/aks-leads

ghost commented 1 year ago

Issue needing attention of @Azure/aks-leads

ghost commented 1 year ago

Issue needing attention of @Azure/aks-leads

ghost commented 1 year ago

Issue needing attention of @Azure/aks-leads

ghost commented 1 year ago

Issue needing attention of @Azure/aks-leads

ghost commented 1 year ago

Issue needing attention of @Azure/aks-leads

microsoft-github-policy-service[bot] commented 6 months ago

Issue needing attention of @Azure/aks-leads

microsoft-github-policy-service[bot] commented 6 months ago

Issue needing attention of @Azure/aks-leads

microsoft-github-policy-service[bot] commented 5 months ago

Issue needing attention of @Azure/aks-leads

microsoft-github-policy-service[bot] commented 5 months ago

Issue needing attention of @Azure/aks-leads

microsoft-github-policy-service[bot] commented 4 months ago

Issue needing attention of @Azure/aks-leads

microsoft-github-policy-service[bot] commented 4 months ago

Issue needing attention of @Azure/aks-leads

microsoft-github-policy-service[bot] commented 3 months ago

Issue needing attention of @Azure/aks-leads

microsoft-github-policy-service[bot] commented 3 months ago

Issue needing attention of @Azure/aks-leads

microsoft-github-policy-service[bot] commented 2 months ago

Issue needing attention of @Azure/aks-leads

microsoft-github-policy-service[bot] commented 2 months ago

Issue needing attention of @Azure/aks-leads

microsoft-github-policy-service[bot] commented 1 month ago

Issue needing attention of @Azure/aks-leads

microsoft-github-policy-service[bot] commented 1 month ago

Issue needing attention of @Azure/aks-leads

microsoft-github-policy-service[bot] commented 3 weeks ago

Issue needing attention of @Azure/aks-leads

microsoft-github-policy-service[bot] commented 6 days ago

Issue needing attention of @Azure/aks-leads