search

Azure / AKS

Azure Kubernetes Service
https://azure.github.io/AKS/
1.95k stars 305 forks source link

Add Tolerations Support to Azure ALB Controller Helm Chart #4370

Open gamoudis opened 2 months ago

gamoudis commented 2 months ago

Hello Azure ALB Controller team,

I would like to request an enhancement to the Azure ALB Controller Helm chart to support adding tolerations to the pod deployment via the values.yaml file. This feature would greatly enhance the flexibility and usability of the Helm chart, especially for deployments in clusters with tainted nodes.

Feature Request:

Add tolerations configuration: Enable users to specify tolerations in the values.yaml file which will be applied to the Azure ALB Controller pods deployments.

Use Case:

In clusters where nodes are tainted for specific purposes (e.g., dedicated nodes for specific workloads, isolating system components, etc.), it's essential to allow the ALB Controller pods to tolerate these taints and schedule them appropriately. Adding this feature will ensure that users can deploy the ALB Controller in diverse and customized environments without manually modifying the Helm chart templates.

Benefits:

Flexibility: Users can deploy the Azure ALB Controller on tainted nodes according to their specific use cases.

Customization: Simplifies the process of customizing the deployment configuration through the values.yaml file.

Ease of use: Avoids the need for users to manually edit Helm chart templates for tolerations, reducing potential errors and simplifying maintenance.

Thank you for considering this enhancement. Looking forward to your positive response.

PixelRobots commented 2 months ago

@JackStromberg Some feedback for you and the team.

JackStromberg commented 2 months ago

Thank you for bubbling up the feedback! Acknowledging the ask -- not planned short-term but will add to our backlog for consideration in future releases.

gamoudis commented 2 months ago

If you make the repository public, We can help by providing the PR.

duncan485 commented 1 month ago

This is such a trivial feature for any helm chart. Please add this or make the chart public so people can contribute. This blocks us from using Azure ALB

JackStromberg commented 1 month ago

@duncan485 -- would you be willing to provide more details about your particular use-case / implementation?

duncan485 commented 1 month ago

@JackStromberg Sure! As the ALB controller would be a critical application for my clusters, I'd like to schedule it on nodes that are reserved for critical workloads, those nodes and are tainted with for example 'CriticalAddonsOnly=true:NoSchedule'.

To be able to schedule the ALB controller on these nodes, I need tolerations.

So in other words I want to run the ALB on the system node pool. Not the user pool.

Just for reference, the AGIC helm chart, does implement this https://github.com/Azure/application-gateway-kubernetes-ingress