Azure / AKS

Azure Kubernetes Service
https://azure.github.io/AKS/
1.97k stars 306 forks source link

[BUG] ALB addon pods should include CriticalAddonsOnly op=Exists toleration #4598

Open ivanthelad opened 5 days ago

ivanthelad commented 5 days ago

Describe the bug The Gateway for containers controller does not tolerate the system-node pools. It should include the toleration. currently it include the default tolerations from the scheduler

To Reproduce None: Inspect the pod alb-controller under the ns azure-alb-system

Expected behavior The ALB pods should have a preference for the system node pools. As they currently don't have that toleration they are repelled by the system pools

Environment (please complete the following information):

ivanthelad commented 4 days ago
helm upgrade alb-controller oci://mcr.microsoft.com/application-lb/charts/alb-controller --post-renderer yq --post-renderer-args 'select(.kind=="Deployment") |= .spec.template.spec.tolerations += [{"key": "CriticalAddonsOnly", "operator": "Exists"}]'

as a workaround to modify ALB controller generated by helm

microsoft-github-policy-service[bot] commented 3 days ago

@JackStromberg would you be able to assist?