Bicep Accelerator Private DNS Zone for "privatelink.*.backup.windowsazure.com" Incorrectly lists uksouth - Githubissues

Azure / ALZ-Bicep

This repository contains the Azure Landing Zones (ALZ) Bicep modules that help deliver and deploy the Azure Landing Zone conceptual architecture in a modular approach. https://aka.ms/alz/docs

MIT License

755 stars 508 forks source link

Bicep Accelerator Private DNS Zone for "privatelink.*.backup.windowsazure.com" Incorrectly lists uksouth #695

Open jamiepla1 opened 10 months ago

jamiepla1 commented 10 months ago

What happened? Provide a clear and concise description of the bug, including deployment details.

When using the Accelerator, I used the location default as uksouth

When referencing the file: config\custom-parameters\hubNetworking.parameters.all.json

for the Private DNS Zone "privatelink.*.backup.windowsazure.com", it uses the region name uksouth rather than the geo code uks

e.g it displays: "privatelink.uksouth.backup.windowsazure.com"

rather than

    "privatelink.uks.backup.windowsazure.com",

Please provide the correlation id associated with your error or bug.

xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx

What was the expected outcome?

No response

Relevant log output

No response

Check previous GitHub issues

[X] I have searched the issues for this item and found no duplicate

Code of Conduct

[X] I agree to follow this project's Code of Conduct

oZakari commented 10 months ago

Good catch, @jamiepla1! We will update the Accelerator configuration to utilize the geo-codes for this private DNS zone.

simonhutson commented 5 months ago

The documentation also needs to be updated to reflect the correct geo codes - https://github.com/Azure/ALZ-Bicep/blob/main/infra-as-code/bicep/modules/vwanConnectivity/README.md.

Refer to the following lists for regions codes: https://download.microsoft.com/download/1/2/6/126a410b-0e06-45ed-b2df-84f353034fa1/AzureRegionCodesList.docx