picccard commented 3 months ago

Overview/Summary

Newer bicep releases adds more linter rules. This PR adds the missing rules from the example linter-config.

If the rules should be error/warning/off...etc. might be changed...

This could potentially be a breaking change.

This PR fixes/adds/changes/removes

Adds more linter rules with default level from the example on ms-docs

Breaking Changes

Could potentially break deployments of customer custom-module ~Could potentially break deployments of internal bicep files~ No error on any .bicep in ALZ-Bicep repo found, fixes for new warnings in #827

Testing Evidence

Linter in VSCode reports no errors. Warnings is fixed in PR #827

As part of this Pull Request I have

[x] Read the Contribution Guide and ensured this PR is compliant with the guide
[ ] Ensured the resource API versions in .bicep file/s I am adding/editing are using the latest API version possible
[x] Checked for duplicate Pull Requests
[ ] Associated it with relevant GitHub Issues
[ ] (ALZ Bicep Core Team Only) Associated it with relevant ADO Items
[x] Ensured my code/branch is up-to-date with the latest changes in the main branch
[ ] Performed testing and provided evidence.
[ ] Updated one or more of the following tests (if required)
[ ] Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Wiki Docs etc.)
[ ] If relevant, created or updated Code Tours here

picccard commented 3 months ago

Tests fails on the link checker... dead links found! 💀

oZakari commented 3 months ago

/azp run validateazcloud

azure-pipelines[bot] commented 3 months ago

Azure Pipelines successfully started running 1 pipeline(s).