fix: Resolve a variety of bugs and update api version of private dns zone links resource

[oZakari]

Overview/Summary

This pull request includes several changes to the Bicep infrastructure code,#815 focusing on parameter handling for availability zones, adding tags to resources, and updating policy assignments. The most important changes are summarized below:

Availability Zones Handling:

• Updated the logic for determining parAvailabilityZones to account for empty values to default to 2 availability zones and specific SKU conditions in various modules (modGatewayPublicIp, modGatewayPublicIpActiveActive, modGatewayPublicIpSecondaryLocation, modGatewayPublicIpActiveActiveSecondaryLocation) in hubNetworking-multiRegion.bicep and hubNetworking.bicep. [1] [2] [3] [4] [5] [6]

Resource Tagging:

• Added tags parameter to several resources in logging.bicep to ensure proper tagging of managed identities, automation accounts, and data collection rules. [1] [2] [3] [4]

Policy Assignments:

• Added parPolicyAssignmentIdentityRoleAssignmentsAdditionalMgs parameter to multiple policy assignment modules to include additional management groups for role assignments in alzDefaultPolicyAssignments.bicep. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10]

Private DNS Zone Links:

• Updated the API version for resPrivateDnsZoneLinkToSpoke resource in privateDnsZoneLinks.bicep to 2024-06-01.

Related Issues/Work Items

Closes #815 Closes #883 Closes #800 Fixes AB#36976 Fixes AB#36410

Breaking Changes

None

Testing Evidence

Tested by deploying over the top of existing deployment of current release.

As part of this Pull Request I have

• [x] Read the Contribution Guide and ensured this PR is compliant with the guide
• [x] Ensured the resource API versions in .bicep file/s I am adding/editing are using the latest API version possible
• [x] Checked for duplicate Pull Requests
• [x] Associated it with relevant GitHub Issues
• [x] (ALZ Bicep Core Team Only) Associated it with relevant ADO Items
• [x] Ensured my code/branch is up-to-date with the latest changes in the main branch
• [ ] Performed testing and provided evidence.
• [ ] Updated one or more of the following tests (if required)
  • Unit
  • Linting
  • E2E (End-To-End)
  • ValidateAzCloud (Base validation in Azure Cloud)
  • ValidateMcCloud (Base validation in Azure China Cloud)
• [ ] Updated relevant and associated documentation (e.g. Contribution Guide, Module READMEs, Wiki Docs etc.)
• [ ] If relevant, created or updated Code Tours here

[oZakari]

/azp run validateazcloud

[azure-pipelines[bot]]

Azure Pipelines successfully started running 1 pipeline(s).