Azure / ALZ-Bicep

This repository contains the Azure Landing Zones (ALZ) Bicep modules that help deliver and deploy the Azure Landing Zone conceptual architecture in a modular approach. https://aka.ms/alz/docs
MIT License
764 stars 514 forks source link

Azure Policy Assignment - Configure Azure PaaS services to use private DNS zones #897

Open gerrynicol opened 2 weeks ago

gerrynicol commented 2 weeks ago

What happened? Provide a clear and concise description of the bug, including deployment details.

It looks like the Table Storage Private DNS Zone is missing from this policy. Is this still an issue as per the link below?

https://github.com/Azure/Enterprise-Scale/issues/1502

Please provide the correlation id associated with your error or bug.

No error, missing DNS zone for table storage

What was the expected outcome?

Zone added

Relevant log output

Check previous GitHub issues

Code of Conduct

oZakari commented 1 week ago

Hi @gerrynicol, this looks to have been corrected in this PR here from the upstream (Enterprise Scale) repo which was just merged.

If you're still having issues, please let us know.

gerrynicol commented 1 week ago

@oZakari I don't think this has been updated in the assignments, only the definition files, based on that link you provided, but I could be wrong

infra-as-code/bicep/modules/policy/definitions/lib/policy_set_definitions/policy_set_definition_es_Deploy-Private-DNS-Zones.json infra-as-code/bicep/modules/policy/definitions/lib/policy_set_definitions/policy_set_definition_es_Deploy-Private-DNS-Zones.parameters.json

oZakari commented 1 week ago

Ah yes, I see what're you saying. Thanks for clarification and good catch! Looks like we missed that in the PR that fixed the definitions. Reopening this.