Azure / ALZ-PowerShell-Module

The Azure Landing Zones Accelerators PowerShell module
https://www.powershellgallery.com/packages/ALZ/
MIT License
77 stars 39 forks source link

Feature Request: ALZ Terraform Accelerator Scenario Feedback #243

Open FreddyAyala opened 1 week ago

FreddyAyala commented 1 week ago

Is there an existing issue for this?

Infrastructure as Code Type? (Required)

terraform

Starter Module? (Required)

bicep - complete

Use Case (Required)

Hello Team, I would like to provide some feedback to Layer 0 regarding the accelerator after deliveries I've made and conversations with other CSAs. The accelerator is truly amazing and serves as our main showcase to guide implementation. However, we've noticed some confusion surrounding the multi-region deployment. The templates available for utilizing tfvars in this deployment can be found here: GitHub Link. These examples demonstrate how to deploy either a multiregional Hub and Spoke or Virtual WAN using tfvars, rather than the .yaml file showcased in the accelerator's wiki. Additionally, the complete multi-region example does not include any policy deployment, necessitating the integration of policy components from here: Policy Components into the multi-region template: Multi-Region Template. This requires us to combine the old way of using .yaml with the newer tfvars method. These complexities make it challenging to deliver clear guidance from the VBD side.

Proposed Solution (Required)

We recommend Layer-0 defining layered core scenarios or examples that seamlessly integrate Governance, Management, and Connectivity (such as hub and spoke, virtual WAN, and multi-region by default but optional) and update the wiki to reflect those changes.

Important Factoids (Optional)

No response

References (Optional)

No response

jaredfholgate commented 1 week ago

Thanks for the feedback. I have been talking to Jamie Pla about a similar subject and looking to make this experience better moving forward.

For clarity, the example tfvars files are currently used to generate the example YAML files. The tfvars are needed for independent testing of the starter module too. They are not currently intended for customer use and as such they are not referenced in our docs.

However, for the sake or usability we want to move towards the tfvars file being the input into the ALZ module and directly used by the starter module. That way there is no confusion and we don't need auto generate YAML examples or transform YAML to json for this part. It will also make future updates in a fire and forget scenarios much easier for the customer.

We will also have the opportunity to provide:

I am unsure about the note on the the starter module not deploying policies? It does deploy the policies.

We are in a transition stage as we move towards a full AVM implementation. We will begin to consolidate and make the options simpler as we move forward. We will also improve the VBD docs as we go.