Azure / AML-Kubernetes

AzureML customer managed k8s compute samples
MIT License
80 stars 32 forks source link

"az ml online-deployment update" doesn't update instance_type from yaml file #247

Closed joaocc closed 1 year ago

joaocc commented 1 year ago

Hi, We are trying to change the instance_type of an existing online-endpoint deployment from "defaultinstancetype" to something else (already created).

We updated the yaml file that was used to create the endpoint originally to point to the new instance_type

---
$schema: https://azuremlschemas.azureedge.net/latest/kubernetesOnlineDeployment.schema.json

endpoint_name: ENDPOINT_NAME_00
type: kubernetes
name: DEPLOYMENT_NAME_00

instance_type: NEW_INST_TYPE_00
# instance_type: defaultinstancetype
instance_count: 1
...

Command executed az ml online-deployment update -f ./azml.deployment.yml -o json --resource-group RGNAME --subscription SUBS_ID --workspace-name WS_NAME

Any alternative besides the following?

We were not able to finds anything in the documentation mentioning that instance_types cannot be created. If argument is ignored, prob would be safer to either abort update or, at least, provide a warning (even if in verbose mode).

Thanks

Zhong-J commented 1 year ago

Hi Joao, today deployment update can't change instance type. The recommended behavior is #2 as you mentioned that deploy a new deployment, move traffic there, and delete the old one. This method is much more secure than updating the old deployment itself.

joaocc commented 1 year ago

Thanks. Maybe this could be added to documentation or, as above, provided as warning on "az ml online-deployment update".