This pull request includes changes to the Scenarios/Secure-Baseline/bicepWithAVM directory, specifically in the 01-Hub/main.bicep, 02-Spoke/README.md, 02-Spoke/main.bicep, and commonModules subdirectories. The changes are focused on modifying the default values, descriptions, and naming conventions of parameters, as well as adding new parameters and functions. The changes also include the addition of new files and modifications to existing ones.
Changes to default values and descriptions:
Scenarios/Secure-Baseline/bicepWithAVM/01-Hub/main.bicep: The default value of enableAvmTelemetry has been changed from false to true. The descriptions and default values of resourceGroupName, virtualNetworkName, defaultSubnetNetworkSecurityGroupName, firewallPublicIpName, firewallManagementPublicIpName, bastionSubnetNetworkSecurityGroupName, firewallName, firewallPolicyName, firewallPolicyRuleGroupName, bastionName, and logAnalyticsWorkspaceName have been updated to reflect new naming conventions. [1][2][3][4]
Scenarios/Secure-Baseline/bicepWithAVM/02-Spoke/main.bicep: A new main.bicep file has been added in the 02-Spoke directory, containing various parameters, variables, and resources for the spoke resource group and the spoke virtual network.
Scenarios/Secure-Baseline/bicepWithAVM/02-Spoke/nsg/jumbox-nsg.jsonc and Scenarios/Secure-Baseline/bicepWithAVM/02-Spoke/nsg/private-endpoints-nsg.jsonc: Two new JSONC files have been added, containing empty security rules for the jumpbox and private endpoints network security groups.
This pull request includes changes to the
Scenarios/Secure-Baseline/bicepWithAVMdirectory, specifically in the01-Hub/main.bicep,02-Spoke/README.md,02-Spoke/main.bicep, andcommonModulessubdirectories. The changes are focused on modifying the default values, descriptions, and naming conventions of parameters, as well as adding new parameters and functions. The changes also include the addition of new files and modifications to existing ones.Changes to default values and descriptions:
Scenarios/Secure-Baseline/bicepWithAVM/01-Hub/main.bicep: The default value ofenableAvmTelemetryhas been changed fromfalsetotrue. The descriptions and default values ofresourceGroupName,virtualNetworkName,defaultSubnetNetworkSecurityGroupName,firewallPublicIpName,firewallManagementPublicIpName,bastionSubnetNetworkSecurityGroupName,firewallName,firewallPolicyName,firewallPolicyRuleGroupName,bastionName, andlogAnalyticsWorkspaceNamehave been updated to reflect new naming conventions. [1] [2] [3] [4]Additions:
Scenarios/Secure-Baseline/bicepWithAVM/02-Spoke/README.md: A new README file has been added, providing an overview of the module and its deployment.Scenarios/Secure-Baseline/bicepWithAVM/02-Spoke/main.bicep: A newmain.bicepfile has been added in the02-Spokedirectory, containing various parameters, variables, and resources for the spoke resource group and the spoke virtual network.Scenarios/Secure-Baseline/bicepWithAVM/02-Spoke/main.bicepparam: A newmain.bicepparamfile has been added, using themain.bicepfile and providing parameters for the hub virtual network ID and the Log Analytics workspace ID.Scenarios/Secure-Baseline/bicepWithAVM/02-Spoke/nsg/jumbox-nsg.jsoncandScenarios/Secure-Baseline/bicepWithAVM/02-Spoke/nsg/private-endpoints-nsg.jsonc: Two new JSONC files have been added, containing empty security rules for the jumpbox and private endpoints network security groups.Scenarios/Secure-Baseline/bicepWithAVM/commonModules/naming/functions.bicep: A new functionreplaceSubnetNamePlaceholdershas been added, which replaces placeholders in the provided name with the provided values.Scenarios/Secure-Baseline/bicepWithAVM/commonModules/network/types.bicep: A new typesubnetTypehas been added, which represents a subnet configuration type.Modifications:
Scenarios/Secure-Baseline/bicepWithAVM/01-Hub/main.bicep: Thebastionmodule has been modified to include apublicIPAddressObjectwith the namebastionPublicIpName, and thediagnosticSettingsparameter has been moved.