search

Azure / ARO-RP

Azure Red Hat OpenShift RP
https://azure.microsoft.com/products/openshift/
Apache License 2.0
98 stars 168 forks source link

condense database patches in install #103

Open jim-minter opened 4 years ago

jim-minter commented 4 years ago

Currently we patch the database adding information all over the place during install, so a sharp-eyed user doing lots of GETs during install will see different values added gradually over the install process.

Would be better to minimise the number of patches and try to get as much of the data added atomically in one place if possible.

m1kola commented 4 years ago

Could you please elaborate on the concern? We don't want users to go to the console while we are still working on provisioning the cluster? Or is there more than this?

I marked it as a low priority (we are still populating console URL and credentials at the end of the installation). Please correct the priority, if you think it should be higher.

jim-minter commented 4 years ago

It's just a bit of a clumsy interface, and it's more database round trips. Nicer for the visible state changes to be closer to atomic. The user can precalculate the console address so it doesn't matter too much to me when they learn it from us; it is important that they can't get the kubeadmin password while we're in Creating, and that is already implemented. Low is fine.