Azure / AVDSessionHostReplacer

MIT License
35 stars 22 forks source link

Domain Join issues fixed #5

Open stephanvandekruis opened 7 months ago

stephanvandekruis commented 7 months ago

Got two errors while deploying to Active Directory joined host pool

The first error was : Unable to process template language expressions for resource '/subscriptions/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/resourceGroups/XXX/providers/Microsoft.Compute/virtualMachines/XXX-02/extensions/DomainJoin' at line '1' and column '7550'. 'The language expression property 'OUPath' doesn't exist, available properties are 'DomainType, ADOUPath, DomainName, DomainJoinUserName'.' (Code: InvalidTemplate)

After changing the "OUPath": "[[parameters('DomainJoinObject').OUPath]" to "OUPath": "[[parameters('DomainJoinObject').ADOUPath]"

Got the following error

Unable to process template language expressions for resource '/subscriptions/xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx/resourceGroups/XXX/providers/Microsoft.Compute/virtualMachines/XXX-02/extensions/DomainJoin' at line '1' and column '7550'. 'The language expression property 'UserName' doesn't exist, available properties are 'DomainType, ADOUPath, DomainName, DomainJoinUserName'.' (Code: InvalidTemplate)

changed "User": "[[format('{0}\{1}', parameters('DomainJoinObject').DomainName, parameters('DomainJoinObject').UserName)]", to "User": "[[format('{0}\{1}', parameters('DomainJoinObject').DomainName, parameters('DomainJoinObject').DomainJoinUserName)]"

Also changed the CodeDeploy.md where TemplateUri should be used instead of TeamplateFile

stephanvandekruis commented 7 months ago

@microsoft-github-policy-service agree

WillyMoselhy commented 7 months ago

Thanks a lot for your commit. I am working on integrating these changes with the main code ASAP