Azure / AppConfiguration-DotnetProvider

The .NET Standard configuration provider for Azure App Configuration
https://github.com/Azure/AppConfiguration
MIT License
76 stars 32 forks source link

Process json key-values without reflection #538

Closed amerjusupovic closed 2 months ago

amerjusupovic commented 3 months ago

One thing to call out, we can disable reflection-based serialization in our unit tests like I added in this PR, but I don't think we can fully test if an application is compatible with AOT without a sample project that has the <PublishAot>true</PublishAot> MSBuild property. I could add that to an existing project or create a new one solely for that purpose. I've tested it locally as AOT and the current examples worked.

avanigupta commented 2 months ago

This also looks like a good candidate for migrating to Utf8JsonReader: https://github.com/Azure/AppConfiguration-DotnetProvider/blob/a81ed763f983b910d95172efe9e56a91c5a5ba32/src/Microsoft.Extensions.Configuration.AzureAppConfiguration/Extensions/EventGridEventExtensions.cs#L38