Azure / AppConfiguration-DotnetProvider

The .NET Standard configuration provider for Azure App Configuration
https://github.com/Azure/AppConfiguration
MIT License
76 stars 32 forks source link

Fix build warning #561

Closed zhiyuanliang-ms closed 2 weeks ago

zhiyuanliang-ms commented 2 weeks ago

Why this PR?

Currently, there are NETSDK1210 and xunit1031 warnings while building .NET provider projects.

For xunit1031 warnings, I had a previous PR #557 which tried to fix it. But somehow I missed something and didn't resolve all the warnings. In this PR, I resolved the remaining warnings.

For NETSDK1210, this is because we have <IsAotCompatible>true</IsAotCompatible> property in Microsoft.Extensions.Configuration.AzureAppConfiguration.csproj. But AOT is only available for .NET 7+. ref Currenly, we are targeting on netstandard.

To suppress the NETSDK1210 warning, we need to add condition for this property.