Azure / AppConfiguration-JavaScriptProvider

The configuration provider for consuming data in Azure App Configuration from JavaScript applications like Node or browser apps.
https://github.com/Azure/AppConfiguration
MIT License
9 stars 2 forks source link

Update typescript version #112

Closed zhiyuanliang-ms closed 1 month ago

zhiyuanliang-ms commented 1 month ago

Why this change

There is a breaking change in 5.6.x: https://devblogs.microsoft.com/typescript/announcing-typescript-5-6/#what’s-new-since-the-beta-and-rc

The interface of ReadonlyMap changed. Our AzureAppConfiguration implements it.

You may see some read underscore in vscode, this is because the built-in typescript version is 5.6+

Visible change

Actually, there won't be visible change for users who consume our package. The compiled file will be written in javascript and there will be no types there. So the compiled outputs will be the same.

Eskibear commented 1 month ago

LGTM to update accordingly if it's a breaking change of ReadOnlyMap declaration from TS 5.6.x. No problem for JS developers. But for TS developers who are using TS Compiler < 5.6.x, can they compile the code after the change? If not, we need to add TS 5.6.x as pre-requisites.

zhiyuanliang-ms commented 1 month ago

LGTM to update accordingly if it's a breaking change of ReadOnlyMap declaration from TS 5.6.x. No problem for JS developers. But for TS developers who are using TS Compiler < 5.6.x, can they compile the code after the change? If not, we need to add TS 5.6.x as pre-requisites.

I updated the dependency in package.json. We required the minimum version to 5.6.3