Registered key-value will not be included in the configuration

Azure / AppConfiguration-JavaScriptProvider

The configuration provider for consuming data in Azure App Configuration from JavaScript applications like Node or browser apps.

https://github.com/Azure/AppConfiguration

MIT License

9 stars 2 forks source link

Registered key-value will not be included in the configuration #93

Open zhiyuanliang-ms opened 2 months ago

zhiyuanliang-ms commented 2 months ago

For dynamic refresh, user can register some keyvalues as watchedSettings. The provider will monitor whether the watchedSettings are changed, if so, the provider will refresh all keyvalue it loaded. But the JS provider will only include keyvalues which selected by selector. The watchedSettings will not be included in the configuration provided by the provider.

This behavior is inconsistent with .NET provider. The screenshot below shows the .NET provider's behavior.

Eskibear commented 2 months ago

It's by design. IMO the sentinel should not be included into configuration if it's not covered by any selector. I remember it has been discussed in the design review. /cc @zhenlan to confirm that.

zhenlan commented 2 months ago

I understand this behavior is different from .NET, but I also remember this has been discussed in a design review. I don't remember the exact reason. Is it consistent with our providers for python and k8s?