Azure / AppConfiguration

Questions, feedback and samples for Azure App Configuration service
MIT License
241 stars 73 forks source link

Feature flags multi label issue ignore cascade settings while update new values #972

Closed knopa closed 2 months ago

knopa commented 2 months ago

For example you have feature flags without label and with label. FeatureA null label FeatureA Stage label You load configuration like that, all works fine without any issues

options.UseFeatureFlags(featureFlagOptions =>
{
    featureFlagOptions
        .Select(KeyFilter.Any)
        .Select(KeyFilter.Any, "Stage");

    featureFlagOptions.CacheExpirationInterval = TimeSpan.FromMinutes(5);
});

App settings and feature flags are populate from Azure Devops pipeline without label from default appsettings.json with overrite option. Settings and feature flags from appsettings.Stage.json only if new keys. All works fine.

But if you have one more enviroment Test for example which use same app configuration but use another label to get feature flags and settings after deploy it update feature flags from default config which detects in app as new updates and in that case FeaterA with null label override Feature Stage label in app and only full config reload helps that. Seems like doesn't respect label settings when register every feature flag for update.

I guess need to register only one KeyFilter when it has more than one label filter

zhenlan commented 2 months ago

Looks like the same issue as https://github.com/Azure/AppConfiguration-DotnetProvider/issues/317

knopa commented 2 months ago

yes, sorry found it later. I think we can close that for now