search

Azure / Azure-Data-Factory-Integration-Runtime-in-Windows-Container

Azure Data Factory Integration Runtime in Windows Container Sample
MIT License
25 stars 36 forks source link

[SHIR] Install Microsoft JDK and then delete msi to decrease image size #17

Closed missingcharacter closed 9 months ago

missingcharacter commented 10 months ago

Included changes:

missingcharacter commented 10 months ago

@microsoft-github-policy-service agree

missingcharacter commented 10 months ago

BTW, I tested the resulting image ghcr.io/missingcharacter/adf-shir:PR-1.6.57b4dde myself and it works, I am able to register a node and able to create parquet files

jikuja commented 10 months ago

BTW, I tested the resulting image ghcr.io/missingcharacter/adf-shir:PR-1.6.57b4dde myself and it works, I am able to register a node and able to create parquet files

Which container orchestration did you use?

missingcharacter commented 10 months ago

Which container orchestration did you use?

@jikuja , I tested on Azure App Service on a Service Plan ith Hyper-V: true

byran77 commented 10 months ago

Hi @missingcharacter, nice points to improve. It would be better to separate the changes into different PRs.

jikuja commented 10 months ago

I have been re-iterating this idea on my head...

Would it be possible to do following:

This would make easier to extend capabilities by adding files just before build process.

byran77 commented 9 months ago

I have been re-iterating this idea on my head...

Would it be possible to do following:

  • create SHIR/scripts/.placeholder
  • move code that installs JVM into contrib/01-install-jvm.ps1
  • modify build.ps1 to execute .ps1 files SHIR/scripts
  • document this

This would make easier to extend capabilities by adding files just before build process.

lgtm It is reasonable to keep only the basic building logic in build.ps1 for better maintainability.

missingcharacter commented 9 months ago

@byran77 I moved GitHub Action to its own PR https://github.com/Azure/Azure-Data-Factory-Integration-Runtime-in-Windows-Container/pull/19

missingcharacter commented 9 months ago

@byran77 I've updated this PR too

byran77 commented 9 months ago

thanks @missingcharacter, it looks good. One more thing is to add some documents on the building argument INSTALL_JDK

missingcharacter commented 9 months ago

@byran77 I added docs