search

Azure / Azure-Data-Factory-Integration-Runtime-in-Windows-Container

Azure Data Factory Integration Runtime in Windows Container Sample
MIT License
25 stars 36 forks source link

[GitHub Actions] Added support for building and pushing container images to ghcr.io #19

Open missingcharacter opened 9 months ago

missingcharacter commented 9 months ago

Why use mr-smithers-excellent/docker-build-push@v6

Why use mr-smithers-excellent/docker-build-push@v6 over docker/login-action@v2 and docker/build-push-action@v4?

docker/build-push-action@v4 does NOT support Windows builds; you can see it here: https://github.com/docker/build-push-action/issues/18, while mr-smithers-excellent/docker-build-push@v6 does support windows builds.

How to push a container to a GitHub Org

diff --git a/.github/workflows/build-docker-image.yml b/.github/workflows/build-docker-image.yml
index 5976088..4f1938b 100644
--- a/.github/workflows/build-docker-image.yml
+++ b/.github/workflows/build-docker-image.yml
@@ -35,5 +35,6 @@ jobs:
           image: adf-shir
           tags: ${{ steps.gen-image-tag.outputs.image_tag }}
           registry: ghcr.io
+          githubOrg: Azure
           username: ${{ github.actor }}
           password: ${{ secrets.GITHUB_TOKEN }}
byran77 commented 9 months ago

thanks @missingcharacter will start a discussion on this change.

missingcharacter commented 3 months ago

@byran77 any news?

byran77 commented 1 month ago

hi @missingcharacter, sorry for the late response. we decide to keep current status in the near future so that users can install the latest stable version in their docker image when building the docker file. We will attempt to add some automatic mechanism in SHIR release process to update the image according to your advice. Thanks!