search

Azure / Azure-DataFactory

Other
485 stars 591 forks source link

Refactor `Push-PipelinesToList` to handle null dependencies #683

Closed Liszet closed 4 months ago

Liszet commented 4 months ago

Refactor the Push-PipelinesToList function in PrePostDeploymentScript.Ver2.ps1 to improve pipeline dependency handling. If a dependency is null, display a warning message identifying which pipeline and activity should be modified. Before the fix, the deployment pipeline would fail without giving any good error message.

Cases where dependency is null -> When one has an execute pipeline in the ADF, that references a pipeline that has been deleted, the activity is set to null. At the moment this does not show up as an error in the 'Validate' step in ADF (as I would expect it would)

Alternative fix: consider throwing an error with the same message, instead of just writing a warning ?

Resolves #679, resolves #678, resolves #675, resolves #431

Liszet commented 4 months ago

@soma-ms Could you take a look at this pull request?

Liszet commented 4 months ago

The ADF product team just fixed the validation in the Data Factory, so now the execute pipelines activities that have no invoked pipeline should show up in the validate step during development