Azure / Azure-Functions

1.12k stars 199 forks source link

Provide an ARM API to download app content #1783

Open shimedh opened 3 years ago

shimedh commented 3 years ago

The primary reason for this is scenario where increased customers are setting up vnet and/or security rules which would not allow us to directly call on their scm URL directly. Also Linux workers have a very limited capability with the scm URLS and we can't use that currently to download the source.

Email thread for reference - https://microsoft-my.sharepoint.com/:b:/p/shimedh/EbPvUwtXD7ZPl6zaLzdbE9sBoADm8Fo-jpsWxnW10oiFVw?e=LTEbkH

@jeffhollan As he is on the email thread where we have discussed this. @nertim, @ehamai FYI

ehamai commented 3 years ago

Just for a bit more context, we're working on a scenario which should help to jump-start the portal to local dev transition and make it way easier to start coding with Functions locally. Having an ARM API (or at least an API which can guarantee network access regardless of the customers app network configuration) to download app content which gives us the equivalent of this direct call (https://${functionAppName}.scm.azurewebsites.net/api/funcons/admin/download?includeCsproj=true&includeAppSengs=true) would increase the reliability and success of this transition.

Adding @anthonychu for visibility since he's been driving a lot of the local dev efforts.