search

Azure / Azure-Functions

1.12k stars 199 forks source link

App content that is downloaded should also bundle together the devcontainer folder if a query string is passed something like ?includeVsCodeDevContainer=true #1784

Open shimedh opened 3 years ago

shimedh commented 3 years ago

Currently the portal is making the mapping of stack to dev container, and vs code is downloading the dev container separately. By having the API already include the dev container as part of the download package streamlines the entire process. This also provides functions the flexibility to change dev containers at a granular level (such as stack, version, sku, etc.)

Email thread for reference - https://microsoft-my.sharepoint.com/:b:/p/shimedh/EbPvUwtXD7ZPl6zaLzdbE9sBoADm8Fo-jpsWxnW10oiFVw?e=LTEbkH

@jeffhollan As he is on the email thread where we have discussed this. @nertim, @ehamai FYI

ehamai commented 3 years ago

For more context, we're working on improving the portal to local dev transition. The way we're doing it is by running a local Docker container on the clients machine which has all of the dependencies that they need to be successful which more reliable than having them install everything on their own for their specific stack. We're working on an update for the Functions VS Code extension which will determine the apps runtime and then download the appropriate container to run successfully.

What Shibani is asking for is if we could bundle the container with the app content API that we're calling so that the extension doesn't have to keep a mapping of which container to download for which stack. This is the call we're currently making to get the app content and settings: (https://${functionAppName}.scm.azurewebsites.net/api/funcons/admin/download?includeCsproj=true&includeAppSengs=true). It would be great if we could modify this API to take in another query string which specifies that we would also like the container information.

And lastly, this is related to #1783, so we'd like for these two feature requests to work together if possible.

Also adding @anthonychu for FYI since he's been working on local dev scenarios.