search

Azure / Azure-Landing-Zones-Library

Library of assets to deploy Azure Landing Zones architectures
https://azure.github.io/Azure-Landing-Zones-Library/
MIT License
24 stars 11 forks source link

Policy assignment definitions deleted in platform/alz/2024.10.0 #77

Closed JWilkinsonMB closed 2 weeks ago

JWilkinsonMB commented 3 weeks ago

It looks like there were a number of policy assignment definitions that were deleted as part of https://github.com/Azure/Azure-Landing-Zones-Library/pull/76, for example platform/alz/policy_assignments/deny_resource_locations.alz_policy_assignment.json

I presume this is correct as I don't see them upstream, but just wanted to confirm that this was the intent, and that if we want to carry on using these assignments that we need to create / copy them into our own library?

Also curious how they got there to begin with as they don't ever seem to have been in the upstream definitions. Looks like it might have come across from CAF? If so is there an argument they should be included to help people migrating?

matt-FFFFFF commented 3 weeks ago

Hi!

As this was a major release, we completely synced with the upstream repo, including removing any assignments that were not there.

There was a lot of debt there as in the old module we didn't delete anything. Hope this helps!

You can always copy the assignment into a local library if you want to.

matt-FFFFFF commented 2 weeks ago

Am going to close this now - feel free to reopen if you need more explanation