Azure / Azure-Landing-Zones-Library

Library of assets to deploy Azure Landing Zones architectures
https://azure.github.io/Azure-Landing-Zones-Library/
MIT License
22 stars 9 forks source link

Some defaults missing for Deploy-Private-DNS-Zones #79

Open JWilkinsonMB opened 5 days ago

JWilkinsonMB commented 5 days ago

It looks some defaults are missing for Deploy-Private-DNS-Zones. Below is what I've deployed in my library to resolve. Is there a standard for naming the defaults for "secondary" zones? I've followed the parameter name which is what the other defaults seem to do, but this results in sec, second & secondary being used interchangeably.

        {
            "default_name": "private_dns_zone_acr",
            "policy_assignments": [
                {
                    "parameter_names": [
                        "azureAcrPrivateDnsZoneId"
                    ],
                    "policy_assignment_name": "Deploy-Private-DNS-Zones"
                }
            ]
        },
        {
            "default_name": "private_dns_bot_service",
            "policy_assignments": [
                {
                    "parameter_names": [
                        "azureBotServicePrivateDnsZoneId"
                    ],
                    "policy_assignment_name": "Deploy-Private-DNS-Zones"
                }
            ]
        },
        {
            "default_name": "private_dns_databricks",
            "policy_assignments": [
                {
                    "parameter_names": [
                        "azureDatabricksPrivateDnsZoneId"
                    ],
                    "policy_assignment_name": "Deploy-Private-DNS-Zones"
                }
            ]
        },
        {
            "default_name": "private_dns_iot_central",
            "policy_assignments": [
                {
                    "parameter_names": [
                        "azureIotCentralPrivateDnsZoneId"
                    ],
                    "policy_assignment_name": "Deploy-Private-DNS-Zones"
                }
            ]
        },
        {
            "default_name": "private_dns_iot_device_update",
            "policy_assignments": [
                {
                    "parameter_names": [
                        "azureIotDeviceupdatePrivateDnsZoneId"
                    ],
                    "policy_assignment_name": "Deploy-Private-DNS-Zones"
                }
            ]
        },
        {
            "default_name": "private_dns_zone_machine_learning_workspace_second",
            "policy_assignments": [
                {
                    "parameter_names": [
                        "azureMachineLearningWorkspaceSecondPrivateDnsZoneId"
                    ],
                    "policy_assignment_name": "Deploy-Private-DNS-Zones"
                }
            ]
        },
        {
            "default_name": "private_dns_zone_site_recovery_backup",
            "policy_assignments": [
                {
                    "parameter_names": [
                        "azureSiteRecoveryBackupPrivateDnsZoneID"
                    ],
                    "policy_assignment_name": "Deploy-Private-DNS-Zones"
                }
            ]
        },
        {
            "default_name": "private_dns_zone_storage_table",
            "policy_assignments": [
                {
                    "parameter_names": [
                        "azureStorageTablePrivateDnsZoneId"
                    ],
                    "policy_assignment_name": "Deploy-Private-DNS-Zones"
                }
            ]
        },
        {
            "default_name": "private_dns_zone_storage_table_secondary",
            "policy_assignments": [
                {
                    "parameter_names": [
                        "azureStorageTableSecondaryPrivateDnsZoneId"
                    ],
                    "policy_assignment_name": "Deploy-Private-DNS-Zones"
                }
            ]
        }
matt-FFFFFF commented 1 day ago

Hi - thank you for this submission. I will add it to a patch release.