search

Azure / Azure-Orbital-Analytics-Samples

Sample solution that demonstrates how to deploy and analyze spaceborne data using Azure Synapse Analytics
https://aka.ms/synapse-geospatial-analytics
MIT License
30 stars 24 forks source link

Fix batch pool name #71

Closed karthick-rn closed 2 years ago

karthick-rn commented 2 years ago

Currently, when provisioning the batch account, the pool name has been created as data-cpu-pool. However, during the creation of the batch job, the pool name is passed with the environment code prefixed. As a result, the batch job is created with a pool name that doesn't exist. This PR fixes the batch pool name to include the environment code as a prefix during creation.

For the record, I have tested this PR with a new batch account and a pre-provisioned batch account; in both cases, the pool name is created with a prefixed environment code. Also, the JSON files have been corrected accordingly.

Additionally, changed the default value to false for PG deployment.

karthick-rn commented 2 years ago

I have also noticed the batch pool name & the job name is the same. In the past, I remember we had the batch job name as 'custom-vision-model-job' with env code prefixed. I think it is good to differentiate both the names. Let me know your thoughts? I can do a follow-up PR.

sushilkm commented 2 years ago

I have also noticed the batch pool name & the job name is the same. In the past, I remember we had the batch job name as 'custom-vision-model-job' with env code prefixed. I think it is good to differentiate both the names. Let me know your thoughts? I can do a follow-up PR.

I dont have a concern regarding the name, since we are generally running only type of pool it should be ok. I wont block the new change, but i dont think it is required as of now.