Azure / Azure-Proactive-Resiliency-Library-v2

Azure Proactive Resiliency Library v2 (APRL) - Source for Azure WAF reliability guidance and associated ARG queries
https://azure.github.io/Azure-Proactive-Resiliency-Library-v2/
MIT License
39 stars 59 forks source link

Update Private end point provisioning success query b89c9acc-0aba-fb44-9ff2-3dbfcf97dce7 #208

Closed basimolimajeed closed 1 week ago

basimolimajeed commented 3 weeks ago

To test for not Succeeded state of a private end point we also need to test the manualPrivateLinkServiceConnections property

Related Issues/Work Items

Breaking Changes

none

As part of this pull request I have

basimolimajeed commented 2 weeks ago

@ejhenry; Here are two screenshots from a test environment. the first shows the manualPrivateLinkServiceConnections properties of the private endpoint so that I can explain the new query. Query 1 The second shows the suggested new query, since all the private endpoints have "provisioningState = Succeeded" then it does not return any results. Query 2

Note: There could be a case for also making sure that the status is also checked (here it is Pending approval since it needs manual approval from the remote resource owner), but I followed the original query in APRL V2 which only checks the "provisioningState" , see the below properties:

"properties": { "provisioningState": "Succeeded", "privateLinkServiceConnectionState": { "description": "APRL test", "status": "Pending", "actionsRequired": "None" },

ejhenry commented 2 weeks ago

@Azure/aprl-networking please review