search

Azure / Azure-Proactive-Resiliency-Library-v2

Azure Proactive Resiliency Library v2 (APRL) - Source for Azure WAF reliability guidance and associated ARG queries
https://azure.github.io/Azure-Proactive-Resiliency-Library-v2/
MIT License
39 stars 59 forks source link

🪲 Bug Report - Configure DDOS Protection on Azure Firewall VNET generates false positive #231

Open davenewman777 opened 1 week ago

davenewman777 commented 1 week ago

Describe the bug

Check to see if firewall VNets are protected by DDOS plan is generating recommendations for change, but protection is already in place.

To Reproduce

Steps to reproduce the behaviour:

  1. Look for the vNet name in the param1 column on the ImpactedResources sheet
  2. Look at the DDOS plan in the portal and see that the networks exist in the list of Protected resources

Expected behaviour

If the vNet listed in the param1 section exists in the Protected resources list, they should not show up as ImpactedResources with a recommendation to do something that already has been done.

Screenshots 📷

image image

Additional context

The firewall objects also are showing as Protected resources on the Firewall tab in DDOS

Dave Newman

oZakari commented 3 days ago

Hi @Azure/aprl-networking, could you please take a look at this one?