search

Azure / Azure-Proactive-Resiliency-Library-v2

Azure Proactive Resiliency Library v2 (APRL) - Source for Azure WAF reliability guidance and associated ARG queries
https://azure.github.io/Azure-Proactive-Resiliency-Library-v2/
MIT License
51 stars 65 forks source link

🪲 Bug Report - Incorrect resource type and count in slide12 #285

Open tksh164 opened 1 month ago

tksh164 commented 1 month ago

Describe the bug

An incorrect resource type and count inserted into the slide 12 that generated by 3_wara_reports_generator.ps1.

To Reproduce

Steps to reproduce the behaviour:

  1. Run the 1_wara_collector.ps1 against a subscription that has less resource types and it has Network Watcher resrouces.
  2. Run the 2_wara_data_analyzer.ps1.
  3. Run the 3_wara_reports_generator.ps1.

Expected behaviour

The correct resource type and its count will be inserted.

Screenshots 📷

image

Additional context

This issue came from the Network Watcher's recommendation (4e133bd0-8762-bc40-a95b-b29142427d73). The recommendation has no resource ID (It has n/a as a resource ID).

image

The inserted content (resource type and count) is generated by unique resource ID, so the Network Watcher's resource type to be / and aggregated count is 1 even if there are multiple Network Watcher resources.

https://github.com/Azure/Azure-Proactive-Resiliency-Library-v2/blob/6b9d9938a30c65a336c6f635c9770ea49ac38547/tools/3_wara_reports_generator.ps1#L203-L221

oZakari commented 1 month ago

@Azure/aprl-wara-tools please review.

kpoineal commented 9 hours ago

@tksh164 Is this still an issue? I believe we fixed the n/a issue in a previous release.