Azure / Azure-Proactive-Resiliency-Library-v2

Azure Proactive Resiliency Library v2 (APRL) - Source for Azure WAF reliability guidance and associated ARG queries
https://azure.github.io/Azure-Proactive-Resiliency-Library-v2/
MIT License
61 stars 70 forks source link

feat: 8-23-2024 WARA Automation Release #367

Closed kpoineal closed 1 month ago

kpoineal commented 1 month ago

Overview/Summary

WARA Collector Script:

Documentation:

Related Issues/Work Items

Closes #175 Closes #148 Closes #176 Closes #292 Closes #324

Breaking Changes

None

As part of this pull request I have

kpoineal commented 1 month ago

Is there a reason this was changed? The one it was changed to looks to updated quite a bit less frequently so I would like to stay with prettier unless there is a specific scenario prettier cannot cover.

I have no idea why/how that got changed.

tksh164 commented 1 month ago

Does the $Script:Version of ps1 scripts remain the same? Looks like those have large changes.

kpoineal commented 1 month ago

Does the $Script:Version of ps1 scripts remain the same? Looks like those have large changes.

I updated the json to 2.0.15 for collector. Is that what you were referring to?

tksh164 commented 1 month ago

I updated the json to 2.0.15 for collector. Is that what you were referring to?

In my understanding, the script compared the version of script itself and JSON to check the latest version.

https://github.com/Azure/Azure-Proactive-Resiliency-Library-v2/blob/927ed6138330a0da31a21e200fad9a746561178c/tools/1_wara_collector.ps1#L1604

https://github.com/Azure/Azure-Proactive-Resiliency-Library-v2/blob/01a8b14c4586a148b61918978e517c702b329622/tools/1_wara_collector.ps1#L390

kpoineal commented 1 month ago

I updated the json to 2.0.15 for collector. Is that what you were referring to?

In my understanding, the script compared the version of script itself and JSON to check the latest version.

https://github.com/Azure/Azure-Proactive-Resiliency-Library-v2/blob/927ed6138330a0da31a21e200fad9a746561178c/tools/1_wara_collector.ps1#L1604

https://github.com/Azure/Azure-Proactive-Resiliency-Library-v2/blob/01a8b14c4586a148b61918978e517c702b329622/tools/1_wara_collector.ps1#L390

This has been fixed. Thank you for pointing this out!

oZakari commented 1 month ago

Discussed with Claudio/Kyle and determined that linter errors not blockers for release.