Azure / Azure-Spring-Apps

Azure Spring Cloud
MIT License
8 stars 6 forks source link

Instrumentation key EoL #18

Open ezYakaEagle442 opened 1 year ago

ezYakaEagle442 commented 1 year ago

Is your feature request related to a problem? Please describe. azureSpringAppsMonitoringSettings required to use the AppInsights Instrumentation key :

resource azureSpringAppsMonitoringSettings 'Microsoft.AppPlatform/Spring/monitoringSettings@2022-09-01-preview' = {
  name: monitoringSettingsName
  parent: azureSpringApps
  properties: {
    appInsightsInstrumentationKey: appInsights.properties.InstrumentationKey
    appInsightsSamplingRate: 10
    // traceEnabled: true Indicates whether enable the trace functionality, which will be deprecated since api version 2020-11-01-preview. Please leverage appInsightsInstrumentationKey to indicate if monitoringSettings enabled or not
  }
}

But https://learn.microsoft.com/en-us/azure/azure-monitor/app/java-in-process-agent#set-the-application-insights-connection-string states :

On March 31, 2025, support for instrumentation key ingestion will end. Instrumentation key ingestion will continue to work, but we'll no longer provide updates or support for the feature. Transition to connection strings to take advantage of new capabilities.

Describe the solution you'd like ASA should be updated accordingly, this will impact all customers with potential outage, having to create new ASA service instances.

The sooner this change is implemented, the better it is as it would impact less customers.

Describe alternatives you've considered N/A

Additional context N/A

domainname commented 1 year ago

We are planning to

  1. Issue a warning when users pass instrumentation key in Azure CLI.
  2. Update Azure Spring Apps docs accordingly, in which we would recommend to use connection string.

A few more things are still pending for discussion. Will update this thread later.